_Blakar_
Posts:
????
Registered:
????
Extended Info (if available)
Real Post Cnt: 0
User ID: 0
|
Subject:
VTank: Lightning Protection/Nether Protection on Armor dumped wrongly?
|
|
I don't know if this is VTank specific issue but when I do a propertydump the LightProt returned it always 1. Which is what Nether Protection always is in the AC identification. I guess the AC client should be right on this so is this fixable?
-----signature-----
|
|
Link to this post
|
PicaroLC
Posts:
????
Registered:
????
Extended Info (if available)
Real Post Cnt: 0
User ID: 0
|
Subject:
VTank: Lightning Protection/Nether Protection on Armor dumped wrongly?
|
I noticed the same issue and submitted bug report PMs to multiple people. I think someone told me it's a decal issue, not vtank.
I have armor rules looking for all 7 protects to be 0.8 or higher (excluding neither protect which is in fact always a 1 for real that I can tell). And keep looting things with "poor" on lightning. The other 6 protects seem to be working fine.
-----signature-----
|
|
Link to this post
|
_Blakar_
Posts:
????
Registered:
????
Extended Info (if available)
Real Post Cnt: 0
User ID: 0
|
Subject:
VTank: Lightning Protection/Nether Protection on Armor dumped wrongly?
|
I fixed this myself.
In the messages.xml the definition is wrong for the return message that contains the protections. When Turbine changed it to include Nether they inserted the float for Nether (which is always 1) before Lightning so it got replaced in Decal. After adding the float for Nether in the definition myself everything works as expected and plugins now get the correct lightProt value (so for example loot profiles in VTank can truly work correct again).
This is a very trivial fix so I suppose Decal team can fix this when they do the memloc update for February patch?
-----signature-----
|
|
Link to this post
|
ColdAvaton
Posts:
????
Registered:
????
Extended Info (if available)
Real Post Cnt: 0
User ID: 0
|
Subject:
VTank: Lightning Protection/Nether Protection on Armor dumped wrongly?
|
|
Is there any way you could copy/paste that for us and tell us exactly where to stick it in the xml file?
-----signature-----
|
|
Link to this post
|
PicaroLC
Posts:
????
Registered:
????
Extended Info (if available)
Real Post Cnt: 0
User ID: 0
|
Subject:
VTank: Lightning Protection/Nether Protection on Armor dumped wrongly?
|
AWESOME!! Thank you. I just did this and mine is working perfectly too now. =)
@ ColdAvaton,
Do a search for protAcid, it'll take you here abouts:
<field name="protAcid" type="float"></field><field name="protLightning" type="float"></field>
Copy this string for Nether:
<field name="protNether" type="float"></field>
Paste the Nether string inbetween the strings for Acid and Lightning:
<field name="protAcid" type="float"></field> **INSERT NETHER HERE** <field name="protLightning" type="float"></field>
You should end up with:
<field name="protAcid" type="float"></field><field name="protNether" type="float"></field><field name="protLightning" type="float"></field>
Now, Lightning will detect correctly, though I notice this does not make Nether show up on the PropertyDump, but who cares, it's always a 1 for real!. =)
Thank you _Blakar_ !!!
-Picaro
-----signature-----
|
|
Link to this post
|
ColdAvaton
Posts:
????
Registered:
????
Extended Info (if available)
Real Post Cnt: 0
User ID: 0
|
Subject:
VTank: Lightning Protection/Nether Protection on Armor dumped wrongly?
|
|
Excellent! Thanks!
-----signature-----
|
|
Link to this post
|
_Blakar_
Posts:
????
Registered:
????
Extended Info (if available)
Real Post Cnt: 0
User ID: 0
|
Subject:
VTank: Lightning Protection/Nether Protection on Armor dumped wrongly?
|
I don't know how the file was made but it contains extremely long lines without linebreaks. As such some editors will have issues editing it. I avoided this by using vi in a cygwin terminal but that isn't exactly a common tool. I don't know either how this is parsed and whether possible format changes editors can make have any effect.
Nevertheless if you have an editor that works with the file you should search for protLightning in the file. It's in a long line and the definition looks like this:
<field name="protLightning" type="float"></field>
Before this definition you'll see the one for Acid which looks the same.
What you do is in between those definitions you paste this:
<field name="protNether" type="float"></field>
After the change Decal will also take into account the additional float that now contains the Lightning protection and as the plugins use the defined name everything works immediately as expected.
-----signature-----
|
|
Link to this post
|
ColdAvaton
Posts:
????
Registered:
????
Extended Info (if available)
Real Post Cnt: 0
User ID: 0
|
Subject:
VTank: Lightning Protection/Nether Protection on Armor dumped wrongly?
|
|
I used Win 7 Notepad and it seems to have worked.
-----signature-----
|
|
Link to this post
|
immortalbob
Title: AC Vault Staff
I am batman!
Posts:
11,887
Registered:
Feb 24, '02
Extended Info (if available)
Real Post Cnt: 11,708
User ID: 649,929
|
Subject:
VTank: Lightning Protection/Nether Protection on Armor dumped wrongly?
|
|
as it turns out, Fire and Cold prots are backwards as well, you can just rearrange them in the xml.
-----signature-----
ImmortalBob, Axer Extraordinaire
+Turbine Sappho tells you, "I am starting to think you are immortal"
|
|
Link to this post
|
PicaroLC
Posts:
????
Registered:
????
Extended Info (if available)
Real Post Cnt: 0
User ID: 0
|
Subject:
VTank: Lightning Protection/Nether Protection on Armor dumped wrongly?
|
immortalbob posted:
as it turns out, Fire and Cold prots are backwards as well, you can just rearrange them in the xml.
LoL, I never even noticed that. Thanks for the info.
-----signature-----
|
|
Link to this post
|
PicaroLC
Posts:
????
Registered:
????
Extended Info (if available)
Real Post Cnt: 0
User ID: 0
|
Subject:
VTank: Lightning Protection/Nether Protection on Armor dumped wrongly?
|
Wait a minute!!!
Do NOT change the order of Fire and Cold in the messages.xml!!
I just checked the order against a pair of boots I have that actually has different values for all 7 protects. Fire and Cold are correct. (even though "/VT PropertyDump" lists them backwards compaired to AC's ID Panel.)
Changing the order only affects how the values list, it does NOT affect how the protection names are listed. Thus you'll actually break Fire and Cold if you reverse them.
-Picaro
-----signature-----
|
|
Link to this post
|
_Blakar_
Posts:
????
Registered:
????
Extended Info (if available)
Real Post Cnt: 0
User ID: 0
|
Subject:
VTank: Lightning Protection/Nether Protection on Armor dumped wrongly?
|
*BUMP*
After update of Decal for Feb you'll need to change the messages.xml again if you want lightning prot to be handled correctly
-----signature-----
|
|
Link to this post
|
Hazridi
Posts:
8,386
Registered:
Mar 15, '01
Extended Info (if available)
Real Post Cnt: 8,277
User ID: 74,558
|
Subject:
VTank: Lightning Protection/Nether Protection on Armor dumped wrongly?
|
|
Post this in the issue thread and I'll try to get the master messages.xml updated tomorrow.
-----signature-----
Hazridi of WE, VT, HG, SC Decal Core Dev - http://www.decaldev.com - Beta at http://www.decaldev.com/beta
|
|
Link to this post
|
PicaroLC
Posts:
????
Registered:
????
Extended Info (if available)
Real Post Cnt: 0
User ID: 0
|
Subject:
VTank: Lightning Protection/Nether Protection on Armor dumped wrongly?
|
|
I posted it for ya _Blakar_.
-----signature-----
|
|
Link to this post
|
Hazridi
Posts:
8,386
Registered:
Mar 15, '01
Extended Info (if available)
Real Post Cnt: 8,277
User ID: 74,558
|
Subject:
VTank: Lightning Protection/Nether Protection on Armor dumped wrongly?
|
|
Okay, if you press update you should get a copy of messages.xml that fixes this problem.
-----signature-----
Hazridi of WE, VT, HG, SC Decal Core Dev - http://www.decaldev.com - Beta at http://www.decaldev.com/beta
|
|
Link to this post
|
