Author Topic: CraftBot Update - Fixed Tinking W/ Salvage
FireSickle 
Posts: ????
Registered: ????
Extended Info (if available)
Real Post Cnt: 0
User ID: 0
Subject: CraftBot Update - Fixed Tinking W/ Salvage
Hello AC Community,

I spent my Christmas vacation working on CraftBot. I disassembled the DLL with Reflector as Paraduck suggested in this thread (http://vnboards.ign.com/ac_utilities/b5432/115752532/p1/) and was able to rewrite it and fix the tinking of Salvage.

Because I disassembled the DLL, instead of using the original Source, I had to touch almost every line of code so there is a chance this new version has bugs introduced that the last version didn't have. I also added brand new code to make salvage work, and that may have introduced new errors...

This topmost post had links to download the program and directions on how to install it (I have not had time to make an installer for this yet, and won't take time to do that until the tink app is finished).

I am taking feedback in this forum post, please let me know of bugs and issues you run into. I do not know any of the old bugs, so please post those too. When I get some more work done with the Source Code, I will post it for anyone to get.

---Download/Install instructions---

(Note, you do not need to reinstall, if you already have this installed, skip the install step)

Download the original installer here:
http://www.firesickle.com/files/CraftBotInstaller.zip

Download the new DLL here:
http://www.firesickle.com/files/CraftBot.dll

Download the new Recipe's file here:
http://www.firesickle.com/files/recipes.xml

(if the recipes file just opens in your web browser, go to File -> SaveAs in your web browser to save it)

(Note, you do not need to reinstall, if you already have this installed, skip the install step)
1) Install CraftBot

2) Overwrite the CraftBot.dll file in your install directory
Default(C:\Program Files\Paraduck\CraftBot\)

3) Overwrite the Recipes.xml file in your mydocuments folder
Default(C:\Documents And Settings\Username\My Documents\Paraduck\CraftBpt)

4) Enjoy some good old tinking...

----

Your old settings should be saved if you already had this installed. I suggest backing everything up, because I am a stickler for that.

Hope to hear back from you guys,
Take care,
FireSickle

 

-----signature-----
Link to this post
FireSickle 
Posts: ????
Registered: ????
Extended Info (if available)
Real Post Cnt: 0
User ID: 0
Subject: CraftBot Update - Fixed Tinking W/ Salvage
CURRENT VERSION
1.11.12.27
Last updated 2AM EST (12/27/2011)

Update Info:
1.11.12.27
Just uploaded the first version of the fix. Have several things I need to look through and test, should be uploading a new version tonight after work (around 11PM EST). I will be around on HG as FireSickle II or Makain most of the evening after 5:30PM EST if you want to get on and chat about anything.


------------------
---KNOWN ISSUES---

-Telling the bot T# will sometimes cause it to tink all the way and blow up your item
----This issue has not been reliably reproduced. Seems to occur most when 7 or more salvages were entered into the trade

-The Workmanship of Salvage is not being displayed properly
-As a result of the Workmanship, the Salvage may not be being organized properly, and will need tested
-The bot's message back about what Salvage it is using is now hardcoded, the message needs cleaned up and a way to identify exactly which bag is in the message should be discovered

 

-----signature-----
Link to this post
Hazridi 
Posts: 8,386
Registered: Mar 15, '01
Extended Info (if available)
Real Post Cnt: 8,277
User ID: 74,558
Subject: CraftBot Update - Fixed Tinking W/ Salvage
you might want to consider keeping a record of your changes and putting the 'source' up somewhere public

 

-----signature-----



Hazridi of WE, VT, HG, SC
Decal Core Dev - http://www.decaldev.com - Beta at http://www.decaldev.com/beta
Link to this post
FireSickle 
Posts: ????
Registered: ????
Extended Info (if available)
Real Post Cnt: 0
User ID: 0
Subject: CraftBot Update - Fixed Tinking W/ Salvage
I will be doing both of those. Right now, the source code is still not finished having all of the objects renamed and the XML data recreated. The disassembled version was obfuscated, and doesn't have comments on top of it, so it's been a pain to bring back from the dead. I just got the web requests working with my website so it will tell you if a new version is available and give you a message about it.

I have an SVN account, so once this is stabilized I will post a public SVN account for others to use. Until I create an actual website for the project, I will track changes and known issues here. I do web programming for a living, so getting a website up is a definite possibility in the near future.

Cheers :-),
FireSickle

EDIT:

Didn't know that I cannot edit my posts after a certain time.
New Version Up:
Version: 2.11.12.001 (changed versioning string so I can do multiple revisions a day if needed)

Added: Requests http://firesickle.com/craftbot/craftbot.php?mode=version&version=CURRENTVERSION to check if the version is up to date
Fixed: Tinking success calculation and Workmanship calculations of added salvage. The sorting of salvage is now fixed as a result

Known Issues:
1) Sometimes the program adds extra items and people to the mailto: list, duplicate records. I was told this is an old issue from the first version, will look into it shortly
2) If you initiate a trade with the bot while it is undressing, it will sometimes cause it to freeze and will not hand back items, even after resetting it with the reset command. ::I have an Idea what causes this, but will require testing::Observed it this morning
3) Sometimes the bot will do all tinks even if you tell it a T# to do. I believe this is a bug due to how that section of code is written (it uses JumpToLine code which isn't always reliable): I am going to rewrite the whole section this weekend and will see if the problem persists.

Looking for feedback and new feature suggestions. I am going to build a chance success calculator for when you are holding items, as well as a pack sorter in the next few weeks as I find time amongst the bug fixes and get more familiar with the last few sections of the code I have not yet commented out.

Happy Tinking


 

-----signature-----
Link to this post
FireSickle 
Posts: ????
Registered: ????
Extended Info (if available)
Real Post Cnt: 0
User ID: 0
Subject: CraftBot Update - Fixed Tinking W/ Salvage
New Version Up: 2.12.01.001

Fixed Salvage Workmanship detection, now rounds to nearest 2 decimal places instead of to the nearest whole number.

Fixed the web requests so it no longer double posts the message.

Added Check Version Button

New version message exposes my email for feature suggestions and bug reporting - I have started working on CraftBot2 (a complete rewrite). I will post again when it goes into the Beta stage (unless there is a critical bug in the current version, I will not post another update until the Beta is ready).

Cheers and happy tinking,
Firesickle

 

-----signature-----
Link to this post
alanothCursor 
Posts: ????
Registered: ????
Extended Info (if available)
Real Post Cnt: 0
User ID: 0
Subject: CraftBot Update - Fixed Tinking W/ Salvage
wowwwwwwwwwwwwwww it was what i searching after the problem of the 2 last updates... i luve you!! happy ).. let me testing that in the week! thk thk thk, i will share

 

-----signature-----
Link to this post
tika_waylen 
Title: Moderator
Dragon Wrangler

Posts: 13,256
Registered: Jun 19, '04
Extended Info (if available)
Real Post Cnt: 12,912
User ID: 935,853
Subject: CraftBot Update - Fixed Tinking W/ Salvage
stupid ? but where is the spell xml file and equipment xml file?

 

-----signature-----
~Proud Monarch to a bunch of unruly Dragons~
http://www.guildportal.com/Guild.aspx?GuildID=24691&TabID=222938
Link to this post
JoxerTMighty 
Title: Captain Canuck
Posts: 4,175
Registered: Apr 3, '01
Extended Info (if available)
Real Post Cnt: 4,140
User ID: 83,588
Subject: CraftBot Update - Fixed Tinking W/ Salvage
this would be even more useful if you built in a buffbot feature with it!
I used to use actool, craftbot, and the buffbot plugin, along with some of the command-line stop/start features to allow my tinker char to also buff others.

 

-----signature-----
(none)
Link to this post
tika_waylen 
Title: Moderator
Dragon Wrangler

Posts: 13,256
Registered: Jun 19, '04
Extended Info (if available)
Real Post Cnt: 12,912
User ID: 935,853
Subject: CraftBot Update - Fixed Tinking W/ Salvage
found it so ignor emy question.

also in case soeone needs the spell id's:

2059: Honed Control
2061: Perseverance
2067: Inner Calm
2087: Might of the Lugians
2091: Mind Blossom
2191: Silencia's Blessing
2195: Aliester's Blessing
2197: Jibril's Blessing
2211: Morimoto's Blessing
2215: Adja's Blessing
2237: Lilitha's Blessing
2251: Yoshi's Blessing
2271: Oswald's Blessing
2277: Celdiseth's Blessing
2287: Nuhmudira's Blessing
2325: Koga's Blessing
2249: Celcynd's Blessing
4297: Incantation of Coordination Self
4299: Incantation of Endurance Self
4305: Incantation of Focus Self
4319: Incantation of Quickness Self
4325: Incantation of Strength Self
4329: Incantation of Willpower Self
4499: Incantation of Arcanum Salvaging Self
4506: Incantation of Alchemy Mastery Self
4510: Incantation of Arcane Enlightenment Self
4512: Incantation of Armor Tinkering Expertise Self
4526: Incantation of Cooking Mastery Self
4530: Incantation of Creature Enchantment Mastery Self
4558: Incantation of Impregnability Self
4560: Incantation of Invulnerability Self
4564: Incantation of Item Enchantment Mastery Self
4566: Incantation of Item Tinkering Expertise Self
4582: Incantation of Life Magic Mastery Self
4586: Incantation of Lockpick Mastery Self
4592: Incantation of Magic Item Tinkering Expertise Self
4596: Incantation of Magic Resistance Self
4640: Incantation of Weapon Tinkering Expertise Self
5068: Incantation of Gear Craft Mastery Self

 

-----signature-----
~Proud Monarch to a bunch of unruly Dragons~
http://www.guildportal.com/Guild.aspx?GuildID=24691&TabID=222938
Link to this post
tika_waylen 
Title: Moderator
Dragon Wrangler

Posts: 13,256
Registered: Jun 19, '04
Extended Info (if available)
Real Post Cnt: 12,912
User ID: 935,853
Subject: CraftBot Update - Fixed Tinking W/ Salvage
ok next stupid question.

i put the buff spells in an order id like for the bot to buff but she isnt doing it in the order i specify. how does it determine the order to buff?

i have 4 level 7's to use as a prebuff so she doesnt fizzle on the 8's but she is going right to the 8's.

 

-----signature-----
~Proud Monarch to a bunch of unruly Dragons~
http://www.guildportal.com/Guild.aspx?GuildID=24691&TabID=222938
Link to this post
Gones_Mage 
Posts: 7,584
Registered: Jul 8, '04
Extended Info (if available)
Real Post Cnt: 7,361
User ID: 942,648
Subject: CraftBot Update - Fixed Tinking W/ Salvage
TAG for use

 

-----signature-----
Gones
Clan Takada
30x275!
Link to this post
KillaCryptic 
Posts: 86
Registered: Feb 9, '07
Extended Info (if available)
Real Post Cnt: 86
User ID: 1,205,110
Subject: CraftBot Update - Fixed Tinking W/ Salvage
Are you able to add a recipe for foolproof salvages? or put it in craftbot 2 for us? Thanks! Works Great!!


~ Xybersoul of Frostfell ~

 

-----signature-----
(none)
Link to this post
Gones_Mage 
Posts: 7,584
Registered: Jul 8, '04
Extended Info (if available)
Real Post Cnt: 7,361
User ID: 942,648
Subject: CraftBot Update - Fixed Tinking W/ Salvage
THX for the work. I look forward to the next updated version.

 

-----signature-----
Gones
Clan Takada
30x275!
Link to this post
KillaCryptic 
Posts: 86
Registered: Feb 9, '07
Extended Info (if available)
Real Post Cnt: 86
User ID: 1,205,110
Subject: CraftBot Update - Fixed Tinking W/ Salvage
bump.. no foolproof recipe anyone make one yet? i need a number for foolproof it seems to not find exact name of it.. any help?

 

-----signature-----
(none)
Link to this post

Valid XHTML 1.0 Transitional Powered by PHP