Author Topic: CraftBot 1.0.2629.8 Released!
Paraduck 
Title: quantum mechanic
Posts: 88,652,030
Registered: Feb 27, '01
Extended Info (if available)
Real Post Cnt: 51,297
User ID: 70,706
Subject: CraftBot 1.0.2629.8 Released!
This release contains a critical bug fix which can cause the bot to steal items.
Bug Fixes:

- Fixed a bug where the bot will not close the trade window and keep items after crafting.

New Features:

- Added toggles for advertising tier 4 rare and mail abilities when a trade window is opened.
To get this release, head on over to the download page.

 

-----signature-----
We are like dwarfs sitting on the shoulders of giants. We see more and things that are more distant than they did,
not because our sight is superior or because we are taller than they, but because they raise us up and their
great stature adds to ours
Link to this post
Schugeldson 
Title: Official Lifestone Polisher
Posts: 1,016
Registered: Mar 25, '02
Extended Info (if available)
Real Post Cnt: 1,000
User ID: 661,202
Subject: CraftBot 1.0.2629.8 Released!
Thank you Paraduck, for getting it out so fast! (Thank you also to IB for testing!) wink

 

-----signature-----
Schugeldson
Proud Lord of the Rings Kinship Leader
Protectors of the Golden Flame http://potgf.rbcb.net
Meneldor server
Link to this post
Schugeldson 
Title: Official Lifestone Polisher
Posts: 1,016
Registered: Mar 25, '02
Extended Info (if available)
Real Post Cnt: 1,000
User ID: 661,202
Subject: CraftBot 1.0.2629.8 Released!
I have discovered another reproducable bug with the bot keeping items:

Upon successful crafting, the person opens the trade window with the bot, but if they push the trade button TWICE FAST (accidentally double clicks the trade button), the item never gets traded and is kept by the bot. We tested this bug after a person had this happen to them (luckily the person said they may have messed up by accidentally clicking the trade button twice), and were able to get it to reproduce.

Sorry for finding bugs, but hopefully it helps others in the long run! happy

Thanks again Paraduck! happy

 

-----signature-----
Schugeldson
Proud Lord of the Rings Kinship Leader
Protectors of the Golden Flame http://potgf.rbcb.net
Meneldor server
Link to this post
immortalbob 
Title: AC Vault Staff
I am batman!

Posts: 11,887
Registered: Feb 24, '02
Extended Info (if available)
Real Post Cnt: 11,708
User ID: 649,929
Subject: CraftBot 1.0.2629.8 Released!
also another bug (posting here as a reminder incase dirk didnt post on the craftbot forums already)

If you check the % on a craft, then clear the window(not closing it) the bot doesn't close the window. If you try another check, the bot will steal the items.

moral of the story, if you wanna clear the window, just close it.

 

-----signature-----
ImmortalBob, Axer Extraordinaire
+Turbine Sappho tells you, "I am starting to think you are immortal"
Link to this post
Paraduck 
Title: quantum mechanic
Posts: 88,652,030
Registered: Feb 27, '01
Extended Info (if available)
Real Post Cnt: 51,297
User ID: 70,706
Subject: CraftBot 1.0.2629.8 Released!
OK, my time is pretty limited for the next couple of days, but I think I see the problem.

IB, I'll send you another PM in a minute. Schugeldson, I'll also send you the version if you want to test it. Unfortunately, I don't have the time to log in and do any sort of thorough test myself.

Changed the following:

- Moved the call to remove the items from the return list to when the trade ends.
- Also added a check here to ensure that the item is not in the inventory before removing. If it is, it won't remove.
- Reset Trade was checking the wrong variable, which in most situations doesn't make a difference. I've corrected this.

 

-----signature-----
We are like dwarfs sitting on the shoulders of giants. We see more and things that are more distant than they did,
not because our sight is superior or because we are taller than they, but because they raise us up and their
great stature adds to ours
Link to this post
Schugeldson 
Title: Official Lifestone Polisher
Posts: 1,016
Registered: Mar 25, '02
Extended Info (if available)
Real Post Cnt: 1,000
User ID: 661,202
Subject: CraftBot 1.0.2629.8 Released!
Thank you. happy

 

-----signature-----
Schugeldson
Proud Lord of the Rings Kinship Leader
Protectors of the Golden Flame http://potgf.rbcb.net
Meneldor server
Link to this post

Valid XHTML 1.0 Transitional Powered by PHP